Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom buffer constructor #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheMadman
Copy link

@TheMadman TheMadman commented Feb 4, 2024

Implements the ability to pass a custom memory buffer for use in the CMS struct.

Could be useful for e.g. mmap'd buffers for graceful restart, shared memory buffers for syncing between processes, etc.

Has appropriate documentation/warnings

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 93.79%. Comparing base (4fd7e2a) to head (d76b55c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   96.88%   93.79%   -3.10%     
==========================================
  Files           2        2              
  Lines         257      274      +17     
==========================================
+ Hits          249      257       +8     
- Misses          8       17       +9     
Files Coverage Δ
src/count_min_sketch.h 100.00% <ø> (ø)
src/count_min_sketch.c 93.30% <52.17%> (-3.32%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant